Skip to content

Fix unused standalone imports warnings#5877

Merged
tdonohue merged 1 commit into
DSpace:mainfrom
hernanhlagos:fix/5866-unused-standalone-imports
Jul 1, 2026
Merged

Fix unused standalone imports warnings#5877
tdonohue merged 1 commit into
DSpace:mainfrom
hernanhlagos:fix/5866-unused-standalone-imports

Conversation

@hernanhlagos

Copy link
Copy Markdown

References

Description

This PR removes unused standalone imports that were causing Angular NG8113 warnings during the build.

Instructions for Reviewers

List of changes in this PR:

  • Removed the unused NgClass import from OrcidBadgeAndTooltipComponent.
  • Removed the unused ThemedFileDownloadLinkComponent import from SubmissionSectionUploadFileComponent.
  • No functional changes were made.

How to test:

  1. Run the Angular build using yarn build or npm run build.
  2. Verify that the NG8113 warnings reported in Unused standalone component imports trigger NG8113 warnings during Angular build #5866 are no longer shown.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug code task themes 1 APPROVAL pull request only requires a single approval to merge port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Jun 30, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jun 30, 2026
@tdonohue tdonohue added this to the 11.0 milestone Jul 1, 2026

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @hernanhlagos ! I've verified this fixes the warnings in the build process.

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 11.0 Release Jul 1, 2026
@tdonohue tdonohue merged commit f112533 into DSpace:main Jul 1, 2026
18 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 11.0 Release Jul 1, 2026
@dspace-bot

Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-10_x:

@tdonohue tdonohue removed the port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug code task themes

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Unused standalone component imports trigger NG8113 warnings during Angular build

5 participants